-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new rule to TPV to workaround wrong remote resource selected or recorded in Galaxy DB #955
Add new rule to TPV to workaround wrong remote resource selected or recorded in Galaxy DB #955
Conversation
.. resource selected or recorded in Galaxy DB
It looks like a good solution to me, but when I wanted to test it on the ESG test Galaxy server, I got an error for the data upload:
EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to test it via https://usegalaxy.esgwps.uno/ before merging (just to be sure, also for testing, you can use the fasta stats tool).
I trust your test. It's great that you tested it with None
as well because that was a probable point of failure.
I requested changes because the rule would crash when anonymous users submit jobs (this is why the TPV dry-run fails).
.. attribute is not available and assume None as default
Co-authored-by: José Manuel Domínguez <[email protected]>
Co-authored-by: José Manuel Domínguez <[email protected]>
Addressed both @kysrpex and @mira-miracoli comments. Thanks for testing; check once again. |
Co-authored-by: José Manuel Domínguez <[email protected]>
I tested it using
tpv dry-run
with scenariosNone
, the name of an existing remote resource, and the name of a non-existing remote resource. It fails and shows a message when a non-existing remote resource is used.Example:
Fail output:
I have also tested the same by adding a
dummy
remote resource and ran 3 jobs each time updating my user preferences todefault
a test pulsar instance anddummy
. It fails only whendummy
is used. Feel free to test it via https://usegalaxy.esgwps.uno/ before merging (just to be sure, also for testing, you can use the fasta stats tool).